Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for writing call metadata to an adjacent JSON file #382

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

chenxiaolong
Copy link
Owner

The JSON file contains all of the metadata known to BCR (which roughly matches the information that can be used in the filename templates). This feature is disabled by default.

The majority of this commit is splitting the call metadata collection out of OutputFilenameGenerator. This is something that should've been done anyway.

The notification delete button logic has also been reworked so that the metadata file is also deleted. If debug mode is enabled, the log file will now also be deleted.

Closes: #380

The JSON file contains all of the metadata known to BCR (which roughly
matches the information that can be used in the filename templates).
This feature is disabled by default.

The majority of this commit is splitting the call metadata collection
out of OutputFilenameGenerator. This is something that should've been
done anyway.

The notification delete button logic has also been reworked so that the
metadata file is also deleted. If debug mode is enabled, the log file
will now also be deleted.

Closes: #380

Signed-off-by: Andrew Gunnerson <[email protected]>
@chenxiaolong chenxiaolong self-assigned this Jul 20, 2023
@chenxiaolong chenxiaolong merged commit a641f82 into master Jul 20, 2023
1 check passed
@chenxiaolong chenxiaolong deleted the json branch July 20, 2023 04:51
chenxiaolong added a commit that referenced this pull request Jul 20, 2023
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for writing a JSON file containing call metadata
1 participant